Added float support for delay in AioPikaBroker#38
Merged
s3rius merged 1 commit intotaskiq-python:masterfrom Apr 20, 2025
Merged
Added float support for delay in AioPikaBroker#38s3rius merged 1 commit intotaskiq-python:masterfrom
s3rius merged 1 commit intotaskiq-python:masterfrom
Conversation
s3rius
approved these changes
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Some use cases require short delays (less than 1 second), which were previously unsupported due to integer-only handling. This change enables more precise control over task delays.
delay Handling:
I deliberately chose not to infer the delay type from labels types.
The delay value is now always and explicitly cast to float, regardless of the original label type.
This enforces strict and predictable behavior, eliminating ambiguity.